DigiView-Android icon indicating copy to clipboard operation
DigiView-Android copied to clipboard

Enhancement: un-force landscape mode

Open squshy7 opened this issue 4 years ago • 6 comments

As per title, default app behavior should follow global orientation settings, and as such allow auto rotate. This is mostly UX related as while I expect the vast majority of users to be using it in landscape, it is a jarring experience to have an app that's not a game force you to turn your phone before you are ready.

Not urgent, recommend for post-beta milestone.

squshy7 avatar May 15 '21 00:05 squshy7

Well, isn't fpv sort of a game ? :p Let's see what people think about this :)

jlucidar avatar May 15 '21 00:05 jlucidar

I don't think it makes sense to enable portrait mode for an app that shows a fullscreen video that's always landscape and will show nothing more than big black bars below/above if it's in portrait, but it definitely needs sensorLandscape at least to be able to rotate to the other landscape. I tried it and nothing seems to break.

fichek avatar May 15 '21 10:05 fichek

I don't think it makes sense to enable portrait mode for an app that shows a fullscreen video that's always landscape and will show nothing more than big black bars below/above if it's in portrait, but it definitely needs sensorLandscape at least to be able to rotate to the other landscape. I tried it and nothing seems to break.

Consider: 1.) If there ends up being any appreciable amount of settings in a settings menu, it is a much better UX to be able to handle these in portrait

2.) Tablets have more than enough screen real estate for portrait to be an acceptable viewing orientation; take in to consideration those tablets whose aspect ratio makes them uncomfortable in landscape

squshy7 avatar May 15 '21 12:05 squshy7

I'd definitely let settings screen rotate to any orientation, not a problem since it's a separate activity, just not convinced about main video player activity needing portrait. I feel like it will just complicate things like #18 - should the overlay be placed over the actual video frame or just bottom left of the entire screen which will just show it over the black bars?

fichek avatar May 15 '21 12:05 fichek

Personally I'd vote the water mark goes in the bottom left of the video frame, this way if in 4:3 and landscape you won't end up with the potential of having half the watermark over black and the other half over video.

D3VL-Jack avatar May 15 '21 21:05 D3VL-Jack

Personally I'd vote the water mark goes in the bottom left of the video frame, this way if in 4:3 and landscape you won't end up with the potential of having half the watermark over black and the other half over video.

It's worse than that, 100% of the watermark is over black on most phones today.

v1

v2

fichek avatar May 15 '21 21:05 fichek