wofi-wifi-menu icon indicating copy to clipboard operation
wofi-wifi-menu copied to clipboard

$RWIDTH calculation doesn't support all display resolutions

Open charlie-haley opened this issue 5 years ago • 3 comments

The way the width of wofi is calculated currently doesn't support all display sizes, we need a better way of calculating this.

A potentially tricky thing that makes this different from rofi, you can't pass the font-size through using -font, it's instead set in .config/wofi/style.css

charlie-haley avatar Apr 30 '20 16:04 charlie-haley

Perhaps the best way to do this would be to set the width specifically/let wofi config decide on the width instead.

I don't believe that the ability to customize width from within the script is of any importance or benefit to the user - what do you think?

Do you, by a chance, have the ability to test some long SSID? A long SSID seems like the only scenario where a set width could potentially be a problem.

A rule such as "if SSID = longer than xy characters, replace chars from xy to end with '...' "

fourstepper avatar May 01 '20 08:05 fourstepper

Do you, by a chance, have the ability to test some long SSID? A long SSID seems like the only scenario where a set width could potentially be a problem.

A rule such as "if SSID = longer than xy characters, replace chars from xy to end with '...' "

The max char count for an SSID is 32, I can test this later, I think replacing it with ... may be a good idea. Might also be best to make the trimming user configurable

charlie-haley avatar May 01 '20 14:05 charlie-haley

I think making it user-configurable adds unnecessary complexity.

The goal is to make any SSID recognizable while making the window as lean as possible (not cover up the whole screen)

Past how many characters would you safely recognize any SSID at your place? Would 12+3 possible dots work?

fourstepper avatar May 04 '20 13:05 fourstepper