foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Feature: Running `forge update` on unsynced repo should run `forge install`

Open sambacha opened this issue 3 years ago • 2 comments
trafficstars

Component

Forge

Have you ensured that all of these are up to date?

  • [X] Foundry
  • [X] Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

No response

Describe the bug

Running forge update first when cloning a repo does not ensure that the submodules are synced/checked out.

sambacha avatar Aug 08 '22 06:08 sambacha

So you want forge update to run forge install and then pull the latest refs?

onbjerg avatar Aug 08 '22 16:08 onbjerg

image cli/src/forge.rs Is this where the modifications should go?

shadyalfred avatar Aug 08 '22 18:08 shadyalfred

@shadyalfred Unsure because @sambacha hasn't clarified yet what the behavior should be

@sambacha Ping

onbjerg avatar Aug 11 '22 18:08 onbjerg

So you want forge update to run forge install and then pull the latest refs?

Sorry just now catching up, yes, it should first install if install successfully then it should update

I can see a reason for it just failing however as well. I think its up to yall do you prefer explicit separation or convenience

sambacha avatar Aug 17 '22 02:08 sambacha

I think this is fixed in the latest release can you confirm @onbjerg ?

at least this behavior is now being done:

$ forge build
Missing dependencies found. Installing now.

sambacha avatar Aug 20 '22 02:08 sambacha

Fixed by #6521 and #6519

sambacha avatar Dec 05 '23 12:12 sambacha