foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Change the defult Contract to Counter

Open Tirthnp opened this issue 3 years ago • 5 comments

Motivation

Solution

Tirthnp avatar Aug 06 '22 01:08 Tirthnp

@mattsse would the changes makes sense ?

Tirthnp avatar Aug 08 '22 18:08 Tirthnp

i kinda dont wanna anchor into the Counter as an example - what's the issue with calling the default contract this name?

gakonst avatar Aug 09 '22 16:08 gakonst

@gakonst Just curious, why not?

I think counter can be an interesting template, because it leaves room to expand it and have forge init include a very simple test suite that demonstrates each test type.

mds1 avatar Aug 09 '22 16:08 mds1

ref https://github.com/foundry-rs/foundry/issues/2451

mattsse avatar Aug 09 '22 17:08 mattsse

i think this is ok, simple enough to resolve #2451, not so big that it will cause a lot of churn over what to add/remove etc

no need to add docs for it although the book does need to be updated since it does reference the default template in some places

onbjerg avatar Aug 09 '22 19:08 onbjerg

Just wanted to confirm about what changes I still need to make ? @onbjerg @mattsse

Tirthnp avatar Aug 12 '22 13:08 Tirthnp