foundry
foundry copied to clipboard
feat(forge): multi chain deployment
follow-ups:
- library - linking (currently it just aborts if it the project requires it)
- Messy
stdoutduring concurrent operations (simulation / broadcasting / verification) - Unite both single and multi deployment flow once the above two are solved.
Ref #2609 for multi chain verification
@joshieDo FYI #2609 now merged
Still going to add simple tests, but opening the PR already for review.
added tests
Would love if @aureliusbtc @mds1 or @hexonaut took it for a test before we merge
Planning to test this week! Will update here afterwards
We still haven't switched to Foundry deployment yet. It's one of the last things we are still using dapp tools for.
Will test these features when we switch over, but probably not for this PR.
Finally got around to testing this. With this PR I'm seeing a non-descript error. Running: forge script script/DeployExistingTokenBridge.s.sol:DeployExistingTokenBridge --use solc:0.8.14 --rpc-url $ETH_RPC_URL --broadcast --verify -vvvv
Which produces:
The application panicked (crashed).
Message: called `Option::unwrap()` on a `None` value
Location: evm/src/executor/backend/mod.rs:587
The crash appears to happen on this line when switching forks twice: https://github.com/makerdao/dss-bridge/pull/2/files#diff-e2a54d4d0ad2ae2494877491f14dffba4442e3ada78d1f1aecf7477e1857345aR47
As I said in our Discord chat, I updated to latest here and it seems to work fine now, so not sure what happened. Appears to work great now!
@joshieDo could you resolve conflicts and feel free to merge! nice work.
bump @joshieDo PTAL re: conflicts, would like to merge this week if poss
resolved pretty easily (maybe too easily..). There were some changes which i was not aware on the master branch, and i'm not quite sure how that may impact this branch
waiting for the CI, and going to run some manual tests meanwhile
manual tests of deployment + verification successfully passed. Pending CI and new changes approval, i think we can merge, and tackle the inevitable issues as they come
SHIP IT
gg
So, what's the API look like on this?
https://ethereum.stackexchange.com/search?q=two+chains+foundry
How do I actually use this for a multi-chain deployment?