foundry icon indicating copy to clipboard operation
foundry copied to clipboard

chore(`cargo deny`): migrate away from `number_prefix`

Open zerosnacks opened this issue 1 month ago • 2 comments

We've currently marked it as ignore in our cargo deny

https://github.com/foundry-rs/foundry/blob/828c8c9412ad18f9548dca788635463657b855fe/deny.toml#L12-L13

Following this reasoning

No direct action required, imo prefer keeping the old crate versus introducing a new recommended: https://crates.io/crates/unit-prefix considering we have a number of dependencies that still rely on number_prefix, some of them being soldeer / cliclack.

Once upstream changes are passed we can migrate away

zerosnacks avatar Nov 18 '25 12:11 zerosnacks

Opened tickets:

  • https://github.com/fadeevab/cliclack/issues/97 To do

  • ~~https://github.com/oli-obk/ui_test/issues/354~~ Resolved in https://github.com/oli-obk/ui_test/releases/tag/0.30.4

zerosnacks avatar Nov 24 '25 10:11 zerosnacks

https://github.com/mario-eth/soldeer/releases/tag/v0.10.0 is out, this should complete the transition; will wait for Soldeer team to propose bump if the logs show any breaking changes.

zerosnacks avatar Dec 05 '25 13:12 zerosnacks

Ref: https://github.com/foundry-rs/foundry/pull/12835

Looks like foundry still uses number_prefix directly: https://github.com/search?q=repo%3Afoundry-rs%2Ffoundry%20number_prefix&type=code, will address

zerosnacks avatar Dec 16 '25 14:12 zerosnacks