pslab-android icon indicating copy to clipboard operation
pslab-android copied to clipboard

fix: time interval unit UI

Open Dishebh opened this issue 1 year ago • 3 comments

Fixes #2188

Changes

  • Fixes time interval Unit UI so it shows up correctly in portrait mode

Screenshots / Recordings

  • Landscape Mode Screenshot 2024-09-10 at 11 12 02 PM

  • Portrait Mode Screenshot 2024-09-10 at 11 12 23 PM

Checklist:

  • [ ] No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • [ ] No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • [ ] Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • [ ] No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Dishebh avatar Sep 10 '24 17:09 Dishebh

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot] avatar Sep 10 '24 17:09 sourcery-ai[bot]

cc @marcnause @AsCress

Dishebh avatar Sep 10 '24 17:09 Dishebh

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/11644641928/artifacts/2136653247

github-actions[bot] avatar Sep 10 '24 17:09 github-actions[bot]

I'm closing this as the target branch is native and we are now focusing on flutter.

CloudyPadmal avatar Jul 19 '25 05:07 CloudyPadmal