badgemagic-android icon indicating copy to clipboard operation
badgemagic-android copied to clipboard

Published 20 hours ago • verified publisher icon fossasia

Support multiple frames

Open TheLastProject opened this issue 5 years ago • 15 comments

Fixes #638

Changes:

  • New "Transfer to badge" screen
  • All transfer buttons now instead add to the "Transfer to badge" screen
  • Transfer button on "Transfer to badge" screen sends all the (up to 8) frames to the badge

Screenshots for the change: photo_2020-02-04_16-27-57 photo_2020-02-04_16-27-58 photo_2020-02-04_16-27-59 photo_2020-02-04_16-29-05

TODO (will need help with this, @adityastic):

  • [ ] Fix text on badges in transfer queue
  • [ ] Fix button alignment in transfer queue
  • [ ] Automatically switch to Transfer to badge screen when hitting transfer on another screen

TheLastProject avatar Feb 04 '20 15:02 TheLastProject

@TheLastProject perfect 🤟. I'm busy with an assignment, will look at it tomorrow morning. Thanks a ton for the pr

adityastic avatar Feb 06 '20 21:02 adityastic

@TheLastProject great job 👍. I was just thinking of the process, should we send all the transfer to the transfer section or follow some better approach? Currently by this pr, if the person wants to transfer a single text they will be navigated to the transfer fragment and they need to manually get back to add more items to transfer. @iamareebjamal what are your thoughts on the workflow of this feature?

adityastic avatar Feb 17 '20 09:02 adityastic

If you look at the code and TODOs: "Automatically switch to Transfer to badge screen when hitting transfer on another screen" is planned for me. But I couldn't get that to work so I'll need help there.

TheLastProject avatar Feb 17 '20 10:02 TheLastProject

If you look at the code and TODOs: "Automatically switch to Transfer to badge screen when hitting transfer on another screen" is planned for me. But I couldn't get that to work so I'll need help there.

Dont worry, I'll help you out with that. Lets get the workflow correct, then we can get this done

adityastic avatar Feb 17 '20 21:02 adityastic

@iamareebjamal please let me know your thoughts on this

adityastic avatar Feb 19 '20 12:02 adityastic

@iamareebjamal any updates? Should we move forward with this approach?

adityastic avatar Mar 05 '20 14:03 adityastic

You know better about the project, so go ahead

iamareebjamal avatar Mar 05 '20 14:03 iamareebjamal

@iamareebjamal great. @TheLastProject If you're free, Please let me know. I'll drop a pr to your branch and let's get this working in the upcoming weekend 👍😊

adityastic avatar Mar 05 '20 20:03 adityastic

Sounds good, I'll have time to look at a PR this weekend probably

TheLastProject avatar Mar 05 '20 20:03 TheLastProject

Just gonna ping here again.

TheLastProject avatar Jul 18 '20 18:07 TheLastProject

Hello, has anything happened here?

FrankyBoy avatar Oct 29 '20 15:10 FrankyBoy

Hello, has anything happened here?

Not really. If you want to take it up, feel free to

adityastic avatar Oct 29 '20 15:10 adityastic

<< has zero idea how anything mobile apps related works :D

FrankyBoy avatar Oct 29 '20 17:10 FrankyBoy

@TheLastProject Hi, we are restarting work on this project. Would you like to fix the failing tests of this pull request?

mariobehling avatar Aug 06 '23 10:08 mariobehling

Well, in 3 years I guess my Android skills probably improved so I may be able to do the tasks without help now but I don't really have the time to finish this currently I'm afraid (still have a big to-do list on my own projects too) so it's probably best if someone else picks this up.

TheLastProject avatar Aug 06 '23 13:08 TheLastProject

Closing this as we have moved to a flutter app now.

mariobehling avatar Jun 16 '24 11:06 mariobehling