apidash icon indicating copy to clipboard operation
apidash copied to clipboard

Support for application/x-www-form-urlencoded Content-Type as body type formdata currently only supports multipart/form-data

Open AcousticDeveloper opened this issue 1 year ago • 7 comments

Describe the bug/problem Currently whenever the formdata is selected as request body, the Content-Type header is set to multipart/form-data but this should be dependent upon whether there is a file being uploaded too or else it can be set to the default application/x-www-form-urlencoded.

Relevant References stackoverflow: application/x-www-form-urlencoded or multipart/form-data? baeldung: Difference Between form-data, x-www-form-urlencoded and raw in Postman

Steps to Reproduce the bug/problem Select POST request in the request method, select formdata as the request body, add only text fields as fields, and then we can either chck the codegen for languages where Content-Type is printed, or else we can print requestModel.requestBodyContentType.header inside codegen files to check the request header.

image

Expected behavior If there aren't any files uploaded i.e. all the fields are of text type and selected type is formdata, then the Content-Type should be set to application/x-www-form-urlencoded, and if there is at least one file in the form data, then the Content-Type should be multipart/form-data. As the default Content-Type for HTML form submission is application/x-www-form-urlencoded, hence it is worth introducing in API dash.

Reference: Mozilla Documentation image

Fixing this should start from introducing a new sub-type inside consts.dart file and then creating a new ContentType for the new type and setting up the Content Type based on whether there are any files associated with the request or not. Below are some code snippets from consts.dart which are to be modified to start working on this issue.

image image

Device Info (The device where you encountered this issue):

  • OS: Debian 12 WSL2 on Windows 11

AcousticDeveloper avatar Mar 20 '24 20:03 AcousticDeveloper

A new content-type needs to be added but in UI it can be done in two ways:

  • Adding x-www-form-urlencoded in content type dropdown. Users will be able to add text fields and select only files containing text data and tells user to switch to multipart/form-data whenever a file with binary content (image, video, etc) is selected.
  • Adding a toggle switch somewhere in existing form-data which defaults to x-www-form-urlencoded and can be toggled to multipart. It will be more intuitive and require less changes in the model. Users will be able to explicitly switch to multipart. It can also automatically switch to multipart whenever a file with binary content (image, video, etc) is selected by the user.

ashitaprasad avatar Apr 15 '24 19:04 ashitaprasad

@ashitaprasad I would like to give it a try

himanshugoyal77 avatar May 27 '24 06:05 himanshugoyal77

Sure @himanshugoyal77 you can give it a try. It will be assigned once you send across a PR.

ashitaprasad avatar May 27 '24 10:05 ashitaprasad

Without this can't use it for getting access tokens for OAuth.

ilovefreesw avatar Aug 20 '24 05:08 ilovefreesw

@ilovefreesw You can use this for getting access tokens for OAuth Just set the field type as String for form data fields

ashitaprasad avatar Aug 25 '24 08:08 ashitaprasad