impacket icon indicating copy to clipboard operation
impacket copied to clipboard

[rbcd.py] Handled SID not found in LDAP error

Open ShutdownRepo opened this issue 3 years ago • 1 comments
trafficstars

When an SID couldn't be found in LDAP, the script was crashing because the get_sid_info() function was returning False but the returned value was then read like a list, hence raising an TypeError: 'bool' object is not subscriptable error. This is fixed now, the value returned by the function is checked before attempting at parsing it.

ShutdownRepo avatar Sep 09 '22 10:09 ShutdownRepo

I can confirm this fix works. Would it be possible to accept this pull request? Currently, rbcd.py is broken when the msDs attribute was previously written but the user in the security descriptor no longer exists.

0xbad53c avatar Jun 02 '24 17:06 0xbad53c