react-dropzone-uploader icon indicating copy to clipboard operation
react-dropzone-uploader copied to clipboard

Add graphics/screenshots of the buttons in Readme

Open shahednasser opened this issue 3 years ago • 18 comments

Add 2 or 3 GIFs to README showcasing the buttons.

Discussed in https://github.com/sButtons/sbuttons/discussions/1631

Originally posted by reev-create June 27, 2022 It would be great and attractive to see some screenshots or previews of the buttons designs in the Readme file

shahednasser avatar Jun 28 '22 19:06 shahednasser

Hi, @shahednasser, Thanks for opening an issue :blue_heart: your issue will be seen by maintainers soon. Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will investigate :eyes: and get back to you as soon as possible :+1: . Just make sure you have given us sufficient information :information_source:. By that time enjoy this joke :point_down: , hope you like it :smile:

What's the object-oriented way to become wealthy?
Inheritance.

Use this action on your projects. Use memes on issues action instead.

github-actions[bot] avatar Jun 28 '22 19:06 github-actions[bot]

I'll soon add the graphical view in the Readme file

reev-create avatar Jun 29 '22 07:06 reev-create

I've assigned you @reev-create

shahednasser avatar Jun 29 '22 08:06 shahednasser

@shahednasser reporting a stale issue.

github-actions[bot] avatar Jul 07 '22 00:07 github-actions[bot]

Hi, @shahednasser, Thanks for opening an issue :blue_heart: your issue will be seen by maintainers soon. Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will investigate :eyes: and get back to you as soon as possible :+1: . Just make sure you have given us sufficient information :information_source:. By that time enjoy this joke :point_down: , hope you like it :smile:

What do you get if you lock a monkey in a room with a typewriter for 8 hours?
A regular expression.

Use this action on your projects. Use memes on issues action instead.

github-actions[bot] avatar Jul 19 '22 09:07 github-actions[bot]

@reev-create are you still working on this?

shahednasser avatar Jul 19 '22 09:07 shahednasser

@shahednasser reporting a stale issue.

github-actions[bot] avatar Jul 27 '22 00:07 github-actions[bot]

Hi is this issue still being worked on by assignee ? If no then I would like to make a contribution.

I am planning to add preview images/gifs next to sample source codes as a table in the Usage section of readme.md


This is a sample how it should look on README.md :

Screenshot 2022-07-31 at 9 33 35 AM

I am currently experimenting with this on my fork's preview_patch branch where you can see how the sample result might look on your particular device/theme.

Arsenic-ATG avatar Jul 31 '22 04:07 Arsenic-ATG

Hello @Arsenic-ATG this sounds great! I'll assign you

shahednasser avatar Aug 05 '22 21:08 shahednasser

@shahednasser

After some playing around with different layouts, I shortlisted two of them

I went ahead and applied the changes on 2 different branches of my fork following the different approaches to see the complete effect it would have on the README.md, and I could really use some help choosing the final design amongst them. 😅

Type 1 (using tables )

Completely implemented in preview_patch branch of the fork

Preview Source
<button class="animated sbtn atom-btn blue-btn">Animated Button</button>

Type 2 (using details )

Completely implemented in alternative_preview branch of the fork

<button class="animated sbtn atom-btn blue-btn">Animated Button</button>
Preview

Arsenic-ATG avatar Aug 07 '22 05:08 Arsenic-ATG

Thank you for all your work! I think type 1 is the better approach.

shahednasser avatar Aug 10 '22 21:08 shahednasser

@shahednasser reporting a stale issue.

github-actions[bot] avatar Aug 27 '22 00:08 github-actions[bot]

Is the issue still open?

manoj1749 avatar Aug 30 '22 16:08 manoj1749

@shahednasser reporting a stale issue.

github-actions[bot] avatar Sep 08 '22 01:09 github-actions[bot]

Is this issue still open?

DotSlash-A avatar Sep 12 '22 07:09 DotSlash-A

@DotSlash-A ,looks like either all the maintainers of the repository are busy or the project has been abandoned by the maintainers.

I also opened a PR regarding the same over a month ago (#1643) but never heard from the maintainers since then, and it got closed after being marked "stale" by the bot due to lack of interactions. ( similar fate is shared by other PRs that were opened after that, including #1644 and #1645 )

I would recommend against wasting your time and effort trying to submit patches here.

In case you still want the project to grow and ready to take the initiative, then it is much better to maintain a separate fork of the project instead ( though make sure to mention this original repo if you are planning to do so )

Arsenic-ATG avatar Sep 12 '22 11:09 Arsenic-ATG

Is this issue still open?

RohitRajvaidya5 avatar Sep 17 '22 03:09 RohitRajvaidya5

@shahednasser reporting a stale issue.

github-actions[bot] avatar Sep 25 '22 01:09 github-actions[bot]