Spotlight button's text color in dark mode

[shahednasser]

In dark mode, Spotlight's text color should be white before the animation as well.

[github-actions[bot]]

Hi, @shahednasser, Thanks for opening an issue :blue_heart: your issue will be seen by maintainers soon. Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will investigate :eyes: and get back to you as soon as possible :+1: . Just make sure you have given us sufficient information :information_source:. By that time enjoy this joke :point_down: , hope you like it :smile:

UDP is better in the COVID era since it avoids unnecessary handshakes.

Use this action on your projects. Use memes on issues action instead.

[JLambertazzo]

Hi! I'd like to work on this issue, can you please assign me?

[Grandstaff79]

Hello, I would like to work on this issue as well, would you assign me ?

[Rhut-virani]

Hello, Can I get assigned to work on this issue?

Edit:

a similar issue is there for Glow button also.

[ej-sanmartin]

Since @crisboxing11 has successfully merged a change regarding this bug, issue should be closed! Did anyone check if this change, however, doesn't affect light mode?

[ej-sanmartin]

Read the commits / merge history wrong, guess now would be a good time to test it out again

[github-actions[bot]]

@shahednasser reporting a stale issue.

[github-actions[bot]]

@shahednasser reporting a stale issue.

[shahednasser]

This issue is still not resolved in case anyone is interested in working on it.

[JLambertazzo]

I'll take it, can you assign me?

[shahednasser]

Sure @JLambertazzo

[JLambertazzo]

I can't get the changes to display on the example site. Setting the button class to dark-mode or it's parent to have data-theme="dark" manually makes it work as expected but by default in dark mode it does not change.

[CodEZ47]

This issue is still not resolved in case anyone is interested in working on it.

Can I work on this issue?

[shahednasser]

@JLambertazzo can you submit a PR so that I can see exactly what's going on?

[JLambertazzo]

Created the pull request, let me know what you think

[github-actions[bot]]

@shahednasser reporting a stale issue.

[Poirei]

Can I join to work on this issue?

[github-actions[bot]]

@shahednasser reporting a stale issue.

[shahednasser]

@Poirei are you still interested in working on this?

[lam-brian]

Hi, can I work on this issue? Also, quick question: Would you want white text on all the spotlight buttons except for the white buttons? Otherwise when you hover it, the text would blend in with the background color.

[shahednasser]

@lam-brian the text in dark mode should be white before the animation. As for after the animation you should just fix the white button to be another color

[github-actions[bot]]

@shahednasser reporting a stale issue.

[Dustpie]

Can I work on this issue please?

[github-actions[bot]]

@shahednasser reporting a stale issue.

[github-actions[bot]]

Hi, @shahednasser, Thanks for opening an issue :blue_heart: your issue will be seen by maintainers soon. Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will investigate :eyes: and get back to you as soon as possible :+1: . Just make sure you have given us sufficient information :information_source:. By that time enjoy this joke :point_down: , hope you like it :smile:

UDP is better in the COVID era since it avoids unnecessary handshakes.

Use this action on your projects. Use memes on issues action instead.

[shahednasser]

Hello @Dustpie are you still interested in working on this?

[rushithakkar873]

Hello @shahednasser, If no one is working on this issue then can I work on it?

[shahednasser]

Hello @Ruc08 sure I'll assign you

[rushithakkar873]

Thank you, @shahednasser! I'm starting to work on it now :)

[rushithakkar873]

Hey @shahednasser,

I'm getting some kind of prompt when I run npm start in terminal which I hadn't faced before and I'm not able see anything on localhost. It would be great if you can help me.