formbricks icon indicating copy to clipboard operation
formbricks copied to clipboard

fix: handle incorrect 2FA OTP error

Open BreakTos opened this issue 1 year ago • 4 comments

What does this PR do?

It shows a toast error for wrong 2FA code entered

Fixes # (issue) fixes #3933

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • [ ] Filled out the "How to test" section in this PR
  • [ ] Read How we Code at Formbricks
  • [ ] Self-reviewed my own code
  • [ ] Commented on my code in hard-to-understand bits
  • [ ] Ran pnpm build
  • [ ] Checked for warnings, there are none
  • [ ] Removed all console.logs
  • [ ] Merged the latest changes from main onto my branch with git pull origin main
  • [ ] My changes don't cause any responsiveness issues
  • [ ] First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • [ ] If a UI change was made: Added a screen recording or screenshots to this PR
  • [ ] Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

  • New Features

    • Enhanced user feedback in the Two-Factor Authentication process with specific error messages for incorrect One-Time Password (OTP) entries.
  • Bug Fixes

    • Implemented error handling for the OTP submission to improve user experience.

BreakTos avatar Oct 20 '24 18:10 BreakTos

@BreakTos is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 20 '24 18:10 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 20 '24 18:10 CLAassistant

Walkthrough

The changes in this pull request enhance the EnterCode component within the EnableTwoFactorModal.tsx file by introducing an error handling mechanism. Specifically, if the response from the enableTwoFactorAuthAction lacks valid data, an error toast is displayed, informing the user that the entered One-Time Password (OTP) is incorrect. This modification aims to improve user feedback during the two-factor authentication process without altering the overall structure of the modal.

Changes

File Path Change Summary
apps/web/app/(app)/environments/[environmentId]/settings/(account)/profile/components/EnableTwoFactorModal.tsx Added error handling to onSubmit function in EnterCode component to show a toast on invalid OTP.

Assessment against linked issues

Objective Addressed Explanation
Display an error message for incorrect 2FA code (#3933)

Suggested labels

bug, good first issue, hacktoberfest, 🕹️ oss.gg, 🕹️ 50 points

Poem

🐇 In the modal bright, a change takes flight,
Enter your code, with all your might.
If it’s wrong, don’t fear,
A toast will appear,
“Try again, dear friend, your success is near!” 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 20 '24 18:10 coderabbitai[bot]

Thank you for following the naming conventions for pull request titles! 🙏

github-actions[bot] avatar Oct 20 '24 18:10 github-actions[bot]

Awarding BreakTos: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/BreakTos

oss-gg[bot] avatar Oct 23 '24 23:10 oss-gg[bot]