forem-browser-extension icon indicating copy to clipboard operation
forem-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon forem

Pull out HTML, CSS and JavaScript scripts from content.js into separate assets

Open nickytonline opened this issue 5 years ago • 2 comments

Currently JS, CSS and HTML are all built via JavaScript in content.js. To be able to maintain the browser extension code base, separate them into assets of their given type and reference them.

This will allow for contributors to be able to make changes a lot more easily.

nickytonline avatar Aug 12 '20 20:08 nickytonline

This works for me as long as it doesn't interfere with the loading in any way. I feel like the way the extension renders before other parts of the HTML is a delicate balance. I assume this is fine but let's make sure this doesn't change behavior.

benhalpern avatar Aug 17 '20 11:08 benhalpern

Would the files be separate for development but rolled into one file for production?

Link2Twenty avatar Aug 17 '20 16:08 Link2Twenty