DEV-Android icon indicating copy to clipboard operation
DEV-Android copied to clipboard

Remove the attribute which fixes the app to portrait mode.

Open VarunBarad opened this issue 6 years ago • 0 comments

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [x] Feature
  • [x] Bug Fix
  • [ ] Documentation Update

Description

The app works only in portrait mode before this. There was a flag which was set so that the app never switched to landscape mode even when user rotates the phone.

Probably because originally we were not saving webview's state and then restoring it. This might have caused the webview to reload the app from scratch and not preserve where user was in the app.

Since the state saving and restoring was added some time ago. This now works smoothly(ish) even after we remove that flag which sets it to portrait-only.

One problem that happens is that user is initially greeted with the splash-screen on rotating the device until the webpage loads.

Related Tickets & Documents

#62

Screenshots/Recordings (if there are UI changes)

There are UI changes but the Android screen capture doesn't correctly pickup the orientation change so not posting any. Since there are no UI changes inside the app, it has just started functioning in landscape mode too now.

[optional] What gif best describes this PR or how it makes you feel?

Dog happily typing on laptop

VarunBarad avatar Nov 21 '19 07:11 VarunBarad