Philip Jägenstedt

Results 1151 comments of Philip Jägenstedt

That script is now in https://github.com/web-platform-tests/wpt-metadata/pull/1762.

It looks like this *shouldn't* happen: https://github.com/web-platform-tests/wpt-pr-bot/blob/b6b7fd1efb22d63f5c94cc39e04cdbd74ac1a8ab/lib/metadata/choose-assignee.js#L16 So the question then becomes why it did. The PR was initially a draft, might that explain it?

Oh, I was just "reviewing" to get inline comments grouped together in a batch, I didn't even consider that activity as a review. But that explains what happened here, thanks!

@KyleJu can we lint for this?

We can fix this by adding a token as a secret that we use only for creating the PR. Unfortunately, the user behind that token would then be the owner...

The effect of this is that human intervention is always required to update the manifest. It looks like this might be the cause of https://github.com/web-platform-tests/wpt-metadata/issues/3480. @past until this is fixed,...

Looks like the issue also affects "Resolve pending metadata" PRs, like https://github.com/web-platform-tests/wpt-metadata/pull/3457.

Yeah, that sounds like it would work!

I agree we might want to be a bit careful about depending on GitHub Actions for things that are critical to the functioning of the WPT project, taking the advice...

Spotted in https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/: > We hope you’ll try out the beta before GitHub Actions is generally available on November 13. So, we need not wait for long before we know...