Pluto.jl icon indicating copy to clipboard operation
Pluto.jl copied to clipboard

Upgrade codemirror with new parser

Open fonsp opened this issue 1 year ago • 2 comments

@savq did incredible work on the Julia parser! https://github.com/JuliaPluto/lezer-julia/pull/7

Fix https://github.com/fonsp/Pluto.jl/issues/2943

fonsp avatar Aug 06 '24 08:08 fonsp

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="codemirror-savq")
julia> using Pluto

github-actions[bot] avatar Aug 06 '24 08:08 github-actions[bot]

@savq mabye you could help with updates to lezer_template and scopestate_statefield? I think the rest is easy enough for me :)

fonsp avatar Aug 06 '24 08:08 fonsp

This PR got stuck because of the pattern matching code by dralletje. I gave it a try but this is way to hard to update, I'm declaring it unmaintainable!

Since we barely use the pattern matching and scopestate system, I will look into removing it and rewriting functionality into simpler (less precise) tree traversal code.

fonsp avatar Jan 03 '25 15:01 fonsp

Ready! Merging soon :)

fonsp avatar Jan 17 '25 22:01 fonsp