laravel-graphql icon indicating copy to clipboard operation
laravel-graphql copied to clipboard

Not compatible with PHP 7.3

Open mfn opened this issue 6 years ago • 1 comments

The latest tagged release as well as master depends on webonxy/graphql ~0.10.2.

This is quite an old version and is not compatible with PHP 7.3 due this somewhere in the webonxy library: PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

This code fragment does not even exist in the latest webonxy release, so it's clear only an upgrade of webonyx can make 7.3 compatibility.

mfn avatar Dec 17 '18 12:12 mfn

Maybe this is a mistake

error code:

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

php version:

PHP 7.3.0 (cli) (built: Dec 7 2018 11:01:10) ( NTS ) Copyright (c) 1997-2018 The PHP Group Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies with Zend OPcache v7.3.0, Copyright (c) 1999-2018, by Zend Technologies

code /src/Executor/Executor.php on line 544

case NodeKind::INLINE_FRAGMENT:
                    if (!$this->shouldIncludeNode($selection) ||
                        !$this->doesFragmentConditionMatch($selection, $runtimeType)
                    ) {
                       continue;
                    }
                    $this->collectFields(
                        $runtimeType,
                        $selection->selectionSet,
                        $fields,
                        $visitedFragmentNames
                    );
                    break;

Teeoo avatar Dec 18 '18 01:12 Teeoo