fog-openstack icon indicating copy to clipboard operation
fog-openstack copied to clipboard

Fix URLs to use v3 when only v2 endpoint is listed in the catalog

Open achevalet opened this issue 5 years ago • 9 comments

It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2 see https://github.com/fog/fog-openstack/issues/492

You guys can probably do something much cleaner as I have poor ruby skills, but it fixes my issue and the tests passed so I'm proposing.. :-)

achevalet avatar Jul 20 '20 10:07 achevalet

Build succeeded.

theopenlab-ci[bot] avatar Jul 20 '20 10:07 theopenlab-ci[bot]

Build failed.

theopenlab-ci[bot] avatar Jul 20 '20 12:07 theopenlab-ci[bot]

Build succeeded.

theopenlab-ci[bot] avatar Jul 20 '20 13:07 theopenlab-ci[bot]

Build succeeded.

theopenlab-ci[bot] avatar Jul 20 '20 13:07 theopenlab-ci[bot]

tested on an OpenStack not exposing a endpoint for v3 and this fix work fine.

pdion891 avatar May 12 '21 20:05 pdion891

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

ShamoX avatar Jan 20 '22 08:01 ShamoX

A test would certainly be good, @achevalet please let us know if you plan to add one.

ares avatar Feb 04 '22 09:02 ares

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

For sure I've only validated the use case that was valid on my side where the /v3 is not exposed.

pdion891 avatar Feb 04 '22 13:02 pdion891

Quite busy, I would be grateful if someone can contribute here

achevalet avatar Feb 04 '22 19:02 achevalet