fog-openstack
fog-openstack copied to clipboard
storage: add openstack_storage_url option
In order to support ACL management in my provider (OVH), I need to have users in a different tenant and I need to use another base URL for my storage calls. In the python client it is implemented using the OS_STORAGE_URL.
This is the equivalent option for fog.
I don't really know how to add tests to this, suggestions are highly welcomed
Signed-off-by: Julien 'Lta' BALLET [email protected]
Build succeeded.
- fog-openstack-unittest-test : SUCCESS in 15m 33s
- fog-openstack-unittest-spec : SUCCESS in 13m 34s
Build succeeded.
- fog-openstack-unittest-test : SUCCESS in 12m 17s
- fog-openstack-unittest-spec : SUCCESS in 19m 01s
Build succeeded.
- fog-openstack-unittest-test : SUCCESS in 11m 26s
- fog-openstack-unittest-spec : SUCCESS in 13m 17s
This looks good. Just a question, see above conversation.
Regarding tests, since you have the module utils you should be able to easily unit test #management_url. For a good explanation and example check out https://chriskottom.com/blog/2015/03/testing-ruby-mixins-in-isolation/
Build succeeded.
- fog-openstack-unittest-test : SUCCESS in 11m 47s
- fog-openstack-unittest-spec : SUCCESS in 13m 41s
@ShamoX seems reasonable to me and should be backwards compatible, thoughts?
Yes, seems good, but adding a test like @gildub proposed would improve confidence.
@elthariel still need help here to do it (even after @gildub proposition) ?