fog-openstack icon indicating copy to clipboard operation
fog-openstack copied to clipboard

storage: add openstack_storage_url option

Open elthariel opened this issue 7 years ago • 7 comments

In order to support ACL management in my provider (OVH), I need to have users in a different tenant and I need to use another base URL for my storage calls. In the python client it is implemented using the OS_STORAGE_URL.

This is the equivalent option for fog.

I don't really know how to add tests to this, suggestions are highly welcomed

Signed-off-by: Julien 'Lta' BALLET [email protected]

elthariel avatar Oct 15 '18 19:10 elthariel

Build succeeded.

theopenlab-ci[bot] avatar Oct 15 '18 20:10 theopenlab-ci[bot]

Build succeeded.

theopenlab-ci[bot] avatar Oct 16 '18 07:10 theopenlab-ci[bot]

Build succeeded.

theopenlab-ci[bot] avatar Oct 16 '18 08:10 theopenlab-ci[bot]

This looks good. Just a question, see above conversation. Regarding tests, since you have the module utils you should be able to easily unit test #management_url. For a good explanation and example check out https://chriskottom.com/blog/2015/03/testing-ruby-mixins-in-isolation/

gildub avatar Oct 18 '18 05:10 gildub

Build succeeded.

theopenlab-ci[bot] avatar Oct 16 '19 13:10 theopenlab-ci[bot]

@ShamoX seems reasonable to me and should be backwards compatible, thoughts?

ares avatar Feb 04 '22 09:02 ares

Yes, seems good, but adding a test like @gildub proposed would improve confidence.

@elthariel still need help here to do it (even after @gildub proposition) ?

ShamoX avatar Feb 04 '22 13:02 ShamoX