python-editor icon indicating copy to clipboard operation
python-editor copied to clipboard

editor can't handle args in editor environment variables

Open carlcosmos opened this issue 4 years ago • 2 comments

common case is our users will have EDITOR set to gvim -f which causes editor to crash.

carlcosmos avatar Jun 09 '21 18:06 carlcosmos

Kind of an old issue. There's a PR for it (#15), but I wasn't sure if it would break editors with whitespace in their names.

fmoo avatar Jun 10 '21 08:06 fmoo

Ah - I didn't catch that issue in advance. Feel free to dupe. Our workaround is to just parse the EDITOR variable before invoking editor. In particular we have a lot of users doing things like 'gvim -f' for a blocking gvim for their other uses cases.

Would it suffice to look for things that look like an optparse/argparse style option? like the pattern " -" or " --" (a space followed by dashes followed by chars) ?

Thanks for responding,

-carl

On Thu, Jun 10, 2021 at 1:10 AM Peter Ruibal @.***> wrote:

Kind of an old issue. There's a PR for it (#15 https://github.com/fmoo/python-editor/pull/15), but I wasn't sure if it would break editors with whitespace in their names.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fmoo/python-editor/issues/32#issuecomment-858410479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUNNAKVTTSRPWFMKDO6RVSLTSBXPXANCNFSM46MSZ3RA .

carlcosmos avatar Jun 10 '21 16:06 carlcosmos