flytepropeller icon indicating copy to clipboard operation
flytepropeller copied to clipboard

Published 20 hours ago • verified publisher icon flyteorg

[Doc] Add Go / dependencies installation instructions

Open kevin85421 opened this issue 2 years ago • 3 comments

TL;DR

as title

Type

  • [ ] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

The instructions are similar to: https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#use-go-v117.

Complete description

as title

Tracking Issue

NA

Follow-up issue

NA

kevin85421 avatar May 14 '23 14:05 kevin85421

Codecov Report

Merging #561 (bdadd4c) into master (9a4ea00) will increase coverage by 0.42%. The diff coverage is n/a.

:exclamation: Current head bdadd4c differs from pull request most recent head c85e57e. Consider uploading reports for the commit c85e57e to get more accurate results

codecov[bot] avatar May 14 '23 15:05 codecov[bot]

Hi @EngHabu, thank you for the review! Do you prefer a permanent link or a normal link?

Example:

  • Permanent link: https://github.com/flyteorg/flytepropeller/blob/9a4ea000af6bb7b959daa00f26abea7c2e3262e7/go.mod#L3

  • Normal link: https://github.com/flyteorg/flytepropeller/blob/master/go.mod#L3

kevin85421 avatar May 15 '23 16:05 kevin85421

Permanent Link I believe will show if there is a mismatch. What do you think?

EngHabu avatar May 15 '23 22:05 EngHabu