flytekit icon indicating copy to clipboard operation
flytekit copied to clipboard

Require docker>=6.0.0 in setup.py

Open rahul-theorem opened this issue 3 years ago • 3 comments
trafficstars

TL;DR

Upgrades the minimum version of docker in flytekit to 6.0.0.

Type

  • [ ] Bug Fix
  • [x] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

Upgrades the minimum version of docker in flytekit to 6.0.0.

Tracking Issue

N/A

Follow-up issue

N/A

rahul-theorem avatar Aug 19 '22 18:08 rahul-theorem

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Aug 19 '22 18:08 welcome[bot]

Thanks! Would you mind also make requirements with python3.7? (until we have more time to split things up, we're running requirements with the minimum supported python version). Did you bump this cuz it was causing a conflict somewhere else?

wild-endeavor avatar Aug 19 '22 22:08 wild-endeavor

@wild-endeavor , original context: https://flyte-org.slack.com/archives/CREL4QVAQ/p1660922404113919. Version 6.0.0 of that package is too recent, how about we only relax the upper bound (to something like <7.0.0) and leave the minimum version as it is?

eapolinario avatar Aug 19 '22 22:08 eapolinario

yeah that sounds good. we're not using it for much really doesn't need to be that strict.

wild-endeavor avatar Aug 29 '22 16:08 wild-endeavor

@rahul-theorem would you mind updating the pr?

wild-endeavor avatar Aug 29 '22 22:08 wild-endeavor

Hey @wild-endeavor picking this back up now, everything should be updated. It looks like a number of dependencies wound up getting downgraded in the lockfiles though (including pandera), so I might need some advice on how to properly run this. Is it recommended to run make requirements inside a clean venv?

rahul-theorem avatar Aug 31 '22 02:08 rahul-theorem

Codecov Report

Merging #1138 (e695520) into master (22580d8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files         288      288           
  Lines       25963    25963           
  Branches     2899     2899           
=======================================
  Hits        17756    17756           
  Misses       7728     7728           
  Partials      479      479           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 31 '22 09:08 codecov[bot]

yeah could you try that? that is weird. and you're running with python 3.7 right? i think we still rely on that. if a clean venv is still causing downgrades let us know. thanks!

wild-endeavor avatar Sep 01 '22 16:09 wild-endeavor

actually holding off... will try to run this later on a new venv

wild-endeavor avatar Sep 08 '22 17:09 wild-endeavor

oh it looks like all the downgrades are happening in the doc requirements file. i think that's okay. it looks like the previous one was generated with 3.9 and now we're using 3.7. i think that's fine. we can bump again separately if needed. 3.9 is probably okay for docs though. cc @eapolinario

merging.

wild-endeavor avatar Sep 08 '22 20:09 wild-endeavor