flytekit-python-template icon indicating copy to clipboard operation
flytekit-python-template copied to clipboard

added -y option to docker_build.sh. I also fixed a bug on -p option

Open masayang opened this issue 2 years ago • 2 comments
trafficstars

I had added a couple of features to the sample template. I also fixed a bug in docker_build.sh

  • Now -p option works correctly.
  • By providing -y option, you can specify a version of Python. Default is 3.8
  • If pipenv is in the path, requirements.txt will be generated through pip freeze
  • If jupyter is in the path, workflows/*.ipynb will be transformed to *.py files.

masayang avatar Jan 31 '23 01:01 masayang

Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

welcome[bot] avatar Jan 31 '23 01:01 welcome[bot]

also, @masayang would you mind following the instructions here for the DCO tests to pass? https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

cosmicBboy avatar Feb 06 '23 21:02 cosmicBboy