flyteconsole icon indicating copy to clipboard operation
flyteconsole copied to clipboard

fix: cross execution breadcrumb link

Open FrankFlitton opened this issue 2 years ago • 1 comments

TL;DR

  • Link to cross namespace workflow/task from the breadcrumb (different origin project/namespace than where it executed)
  • Better self link markup

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [x] Code completed
  • [x] Smoke tested
  • [ ] Unit tests added
  • [x] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

Used the launch plan spec for the execution to compare against.

Tracking Issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA

FrankFlitton avatar Sep 08 '23 23:09 FrankFlitton

Codecov Report

Patch coverage has no change and project coverage change: -0.04% :warning:

Comparison is base (a4348d8) 63.36% compared to head (205e500) 63.32%.

:exclamation: Current head 205e500 differs from pull request most recent head a34f304. Consider uploading reports for the commit a34f304 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   63.36%   63.32%   -0.04%     
==========================================
  Files         527      527              
  Lines       13396    13403       +7     
  Branches     2550     2553       +3     
==========================================
  Hits         8488     8488              
- Misses       4908     4915       +7     
Files Changed Coverage Δ
...s/Breadcrumbs/components/BreadcrumbFormControl.tsx 12.08% <0.00%> (-1.01%) :arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 09 '23 00:09 codecov[bot]