source-controller icon indicating copy to clipboard operation
source-controller copied to clipboard

make controller adhere to spec.timeout for git operations

Open makkes opened this issue 3 years ago • 1 comments

spec.timeout was consumed twice in a row in scenarios where the optimized clone isn't possible (i.e. when a new commit has been pushed) leading to the overall time of git operations during a single reconciliation possibly reaching 2*spec.timeout. With this change, the field is only consumed once and used for both git operations together.

closes #742

makkes avatar Jun 10 '22 11:06 makkes

Still need to figure out how to properly create a regression test for this change.

makkes avatar Jun 10 '22 11:06 makkes

closing as we will stick to the current behaviour. See the linked issue for details.

makkes avatar Aug 31 '22 11:08 makkes