flagger icon indicating copy to clipboard operation
flagger copied to clipboard

fix: correct typo in AutoscalerReference type name

Open kahirokunn opened this issue 11 months ago • 2 comments

  • Fix spelling of AutoscalerReference (was AutoscalerRefernce) in type definition and struct field

kahirokunn avatar Dec 12 '24 00:12 kahirokunn

Codecov Report

:x: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 28.43%. Comparing base (12ee6cb) to head (56200f6). :warning: Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/flagger/v1beta1/zz_generated.deepcopy.go 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1739       +/-   ##
===========================================
- Coverage   39.44%   28.43%   -11.01%     
===========================================
  Files         287      287               
  Lines       22706    22802       +96     
===========================================
- Hits         8956     6484     -2472     
- Misses      12777    15596     +2819     
+ Partials      973      722      -251     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 17 '24 06:12 codecov-commenter

@aryan9600 Hello! Could I have a review?

kahirokunn avatar Feb 26 '25 01:02 kahirokunn

Bump

kahirokunn avatar Sep 04 '25 23:09 kahirokunn

This rename needs to happen in other places too, please run the tests locally. From CI:

Error: pkg/controller/controller_test.go:141:32: undefined: flaggerv1.AutoscalerRefernce

stefanprodan avatar Oct 07 '25 06:10 stefanprodan

Thank you! I've made the correction. 🙏

kahirokunn avatar Oct 07 '25 09:10 kahirokunn