website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[WIP]: FWE (v2) User Input

Open khanhnwin opened this issue 1 year ago • 4 comments
trafficstars

Description of what this PR is changing or adding, and why: Adding V2 FWE page for User Input.

khanhnwin avatar Aug 21 '24 23:08 khanhnwin

Visit the preview URL for this PR (updated for commit fa8d9636771f24e237d10ab6efae9807e4974cf4):

https://flutter-docs-prod--pr11072-fwe-v2-user-input-1cop91je.web.app

flutter-website-bot avatar Aug 21 '24 23:08 flutter-website-bot

Sorry Shams! This PR isn't done yet. I just wanted to create it so that you and Eric could leave comments while I'm still adding to it.

khanhnwin avatar Aug 22 '24 19:08 khanhnwin

Khanh and I talked about this via email, so for posterity -- I think this page looks great now, and I'm comfortable calling the content V2 complete. I still need to review for nits

ericwindmill avatar Aug 23 '24 13:08 ericwindmill

Oh, I saw that, @khanhnwin (that it wasn't done yet), but I like to get a head start, sometimes. :D

sfshaza2 avatar Aug 23 '24 19:08 sfshaza2

Alrighty, I think we're ready for round 2 @sfshaza2 @ericwindmill! Thank you!

khanhnwin avatar Sep 04 '24 23:09 khanhnwin

Thanks for the review @ericwindmill! Back to you @sfshaza2!

khanhnwin avatar Sep 10 '24 21:09 khanhnwin

/gcbrun

khanhnwin avatar Sep 13 '24 15:09 khanhnwin

I went through and triple checked your fixes @sfshaza2 - I think everything's been accounted for. It looks like you might have had an older version of the branch because a lot of the comments were already addressed/out of date by the time I went through them. Thanks for the thorough review!!

khanhnwin avatar Sep 13 '24 15:09 khanhnwin