website icon indicating copy to clipboard operation
website copied to clipboard

[Fix] Formatting

Open piedcipher opened this issue 1 year ago • 2 comments
trafficstars

Fix Formatting.

Fixes #10725

Presubmit checklist

  • [x] This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • [x] This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • [x] This PR uses semantic line breaks of 80 characters or fewer.

piedcipher avatar Aug 07 '24 16:08 piedcipher

Visit the preview URL for this PR (updated for commit 8572493bef35061fda570dba97174e87d911c60d):

https://flutter-docs-prod--pr11021-fix-10725-yh3wme43.web.app

flutter-website-bot avatar Aug 07 '24 16:08 flutter-website-bot

I dare not insert myself here. When you are back, @parlough, can you address this one?

sfshaza2 avatar Aug 19 '24 18:08 sfshaza2

/gcbrun

sfshaza2 avatar Aug 29 '24 19:08 sfshaza2

Thanks for thinking about improving this!

For some reason it's not triggering, but CI is supposed to include a formatting check against these files with dart format. Running dart format will revert many of these changes. I'll work on fixing that check. (Edit: #11027)

What do you think about instead moving the docregion comments above the previous line (like child: ...)? It will end up showing some extra information, but I think that's okay considering the examples. We can remove those properties with other code excerpt functionality if needed as well.

hey sry, i missed this. when i tried to run some excerpter generation command locally i got an error. that's what i remember last.

piedcipher avatar Sep 09 '24 16:09 piedcipher