samples icon indicating copy to clipboard operation
samples copied to clipboard

Migrate game_template to Material 3

Open miquelbeltran opened this issue 2 years ago • 2 comments

Migrated game_template to Material 3

Basically, the only thing that changes is the ElevatedButton that has been replaced by a FilledButton.

Before Material 3

Screenshot 2023-01-31 at 14 56 28 Screenshot 2023-01-31 at 14 56 32 Screenshot 2023-01-31 at 14 56 41 Screenshot 2023-01-31 at 14 56 55

With Material 3

Screenshot 2023-01-31 at 15 15 59 Screenshot 2023-01-31 at 15 15 47 Screenshot 2023-01-31 at 15 15 43

Pre-launch Checklist

  • [x] I read the Flutter Style Guide recently, and have followed its advice.
  • [x] I signed the CLA.
  • [x] I read the Contributors Guide.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

miquelbeltran avatar Jan 31 '23 14:01 miquelbeltran

Looking at the failing test

miquelbeltran avatar Jan 31 '23 14:01 miquelbeltran

The test failure is caused by the _SettingsLine for Reset Progress. I guess the Material 3 font is a bit larger, and it causes the menu to overflow for 4 pixels. Just changing the text to Reset Progres (one char less) the test passes. Trying to look for a solution now.

miquelbeltran avatar Jan 31 '23 15:01 miquelbeltran