flutter
Move `web/particle_background` to top level
Pre-launch Checklist
- [x] I read the Flutter Style Guide recently, and have followed its advice.
- [x] I signed the CLA.
- [x] I read the Contributors Guide.
- [x] I updated/added relevant documentation (doc comments with
///). - [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-devrel channel on Discord.
We should probably review the code in lib/ to make sure it abides by best-practices for animation
John, are you volunteering to do a review, or have a link to a doc that lists the best practices for animations? It looked fine to me, but I'm the first to admit I have things to learn here.
I can review it if you like. Are we promoting this demo app to a sample? Most of the code in the web/ directory falls into the "web demo" bucket IMO. From what I can tell, this demo is using some advanced approaches, which might or might not be useful for everyday Flutter developers browsing the code at the root of this project.
I can review it if you like. Are we promoting this demo app to a sample? Most of the code in the
web/directory falls into the "web demo" bucket IMO. From what I can tell, this demo is using some advanced approaches, which might or might not be useful for everyday Flutter developers browsing the code at the root of this project.
My vote is to keep this sample as it creates an interesting effect. I updated it to be usable on desktop, mobile and web.
Do we need an advanced sub directory for the samples? For what it's worth, there are other samples at the top level that would probably also be equally classifiable as advanced use cases.
I would vote to add this code to the animations sample I think.
Can you take a quick pass through the code for compliance before I do the lift and shift work of merging it into the animations sample?
I dug in further, and realised this sample had an inlined old copy of simple_animations package. Droppping.