samples icon indicating copy to clipboard operation
samples copied to clipboard
verified publisher icon flutter

Update `navigation_and_routing` sample to `go_router` 5

Open johnpryan opened this issue 3 years ago • 1 comments

Updates the navigation_and_routing sample to go_router 5.

Depends on https://github.com/flutter/flutter/issues/111981

Pre-launch Checklist

  • [x] I read the [Flutter Style Guide] recently, and have followed its advice.
  • [x] I signed the [CLA].
  • [x] I read the [Contributors Guide].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] All existing and new tests are passing.

johnpryan avatar Sep 20 '22 18:09 johnpryan

I'm curious why CI is red, any ideas?

domesticmouse avatar Sep 21 '22 20:09 domesticmouse

I wanted to enable Material 3 on this sample, but since I saw this PR open, I didn't want to mess with the work and cause a merge conflict, so I wanted to ask first. How do you prefer me to proceed?

miquelbeltran avatar Feb 01 '23 14:02 miquelbeltran

Brett, do you see https://github.com/flutter/samples/pull/1437#discussion_r976972745 as a blocker or should we try to merge this PR?

johnpryan avatar Feb 06 '23 21:02 johnpryan