samples icon indicating copy to clipboard operation
samples copied to clipboard

add thumbnails to the books example to make memory leaks easier to test

Open xster opened this issue 3 years ago • 8 comments

xster avatar Jul 29 '22 06:07 xster

PTAL @craiglabenz

domesticmouse avatar Aug 03 '22 10:08 domesticmouse

Sorry, I was away last week. The last error was unrelated (different package in this repo). Re-sync'ing to see if it goes away

xster avatar Aug 09 '22 06:08 xster

oh, it looks like the single PR https://github.com/flutter/flutter/pull/105291 both added a new API backgroundColor, and deprecated the previous API onPrimary, making it impossible for the same code to pass on both stable and beta

xster avatar Aug 09 '22 07:08 xster

since stable and beta conflicts for various packages in this repo, I added lint ignores for now.

@domesticmouse let me know if there's a system in place you'd like me to follow instead? Otherwise, I'd propose running the CI every 24h even when there's no PRs, just to make sure samples code on head can build against the beta on head

xster avatar Aug 09 '22 07:08 xster

oh, I can't merge. So someone will have to do it for me

xster avatar Aug 09 '22 07:08 xster

@domesticmouse can you merge this for me?

xster avatar Aug 09 '22 19:08 xster

Nope, I'm not an authorized lander. PTAL @craiglabenz

domesticmouse avatar Aug 09 '22 20:08 domesticmouse

@domesticmouse let me know if there's a system in place you'd like me to follow instead? Otherwise, I'd propose running the CI every 24h even when there's no PRs, just to make sure samples code on head can build against the beta on head

IIUC we are running both stable and beta CI daily. If not, please feel free to raise a bug and/or a PR to fix

context: https://github.com/flutter/samples/blob/main/.github/workflows/main.yml#L13

domesticmouse avatar Aug 09 '22 22:08 domesticmouse

@RedBrogdon, @craiglabenz can someone help merge?

xster avatar Aug 22 '22 19:08 xster

PTAL @craiglabenz

domesticmouse avatar Aug 23 '22 00:08 domesticmouse

does @johnpryan have merge rights? Something seems off if @domesticmouse can't merge in this repo.

xster avatar Aug 24 '22 04:08 xster

does @johnpryan have merge rights? Something seems off if @domesticmouse can't merge in this repo.

I can merge most PRs on this repository, I'm unsure why this one is different.

Calling Git magicians @kevmoo and @Hixie

domesticmouse avatar Aug 24 '22 04:08 domesticmouse

Perhaps it wants to be against main?

dnfield avatar Aug 24 '22 06:08 dnfield