plugins
plugins copied to clipboard
flutter
[webview_flutter] Support basic auth requests
Description
This enables the webview to visit http basic auth protected websites.
Related Issues
Originally, it was attempted to implement this here: https://github.com/flutter/plugins/pull/1283 But the author then decided to split up the features into smaller pull requests. However, the one for auth requests was never opened, only for the other features: https://github.com/flutter/plugins/pull/1389
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
- [x] All existing and new tests are passing.
- [x] I updated/added relevant documentation (doc comments with
///). - [x] The analyzer (
flutter analyze) does not report any problems on my PR. - [x] I read and followed the Flutter Style Guide.
- [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
- [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
- [x] I updated CHANGELOG.md to add a description of the change.
- [x] I signed the CLA.
- [x] I am willing to follow-up on review comments in a timely manner.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
- [x] No, this is not a breaking change.
Any idea when this feature will be available? Thanks in advance!
As soon as someone from Google presses the green merge button here... Which unfortunately takes a very long time.
@wwwdata thank you for working on this feature. It seems that its nearing completion, cant wait!
We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
It looks like this should be pretty straightforward to review, and has good test coverage. If you're still interested in moving forward with this, once you've updated this to apply to the current version of the plugin I can review it.
(FYI the mass of CI failures is from an infrastructure issue we hit; the next time you merge/rebase it'll clear up.)
just pushed my changes again. I hope it's ok now. Sorry for the delay I was on vacation
@stuartmorgan is there still something missing in this PR? 🤔️ (except fixing the changelog conflict) thanks.
@stuartmorgan yes that makes sense. So please go ahead and take over with the splitting and so on. Thank you very much!
Per discussion with @bparrishMines I'm going to hold off on updating this until the in-progress conversion is complete.
Is there still a conversion in progress? I guess the original federated plugin changes are done? @stuartmorgan I have seen the iOS implementation has still some refactoring in progress? https://github.com/flutter/plugins/pull/4626 I guess working on this still doesn't make sense while that is still going on? 🤔️
Is there still a conversion in progress? I guess the original federated plugin changes are done?
This isn't about federation, it's about https://github.com/flutter/flutter/issues/93732 which is still in progress.
Triage update: iOS webview conversion is still in progress, so this still blocked for the moment.
Latest status is that we're still waiting on https://github.com/flutter/flutter/issues/93732. Before this can land even after that is fixed, the conflicts will need to be resolved.
The Dart conversion is complete, but in the meantime we found https://github.com/flutter/flutter/issues/94051 which blocks this, since we currently implement WebViewPlatformCallbacksHandler in our implementations, making changes to it breaking changes. We're actively working on that issue, and hope to have it resolved soon.
Status update from triage: this is still blocked, but we hope to have it unblocked soon.
This is unblocked now that v4 has landed. @bparrishMines This is one we should look at updating.
Update from triage: this is still on our list to update; we're currently working through updating a couple of higher-priority webview features, but we'll get to this soon.
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.
Per discussion above about this PR having fallen through the cracks, either I or @bparrishMines will be opening an updated version of this PR in flutter/packages, so there's no need for any action here. Per my comment above, we expect to get to this fairly soon.