packages
packages copied to clipboard
[go_router] add initial json support #110781
Add initial json support for use in go_router_builder Adds annotation that enable custom string encoder/decoder, its enable conversion for base64
This allow custom type conversion for parameters, like mentionated in #117261 and #110781
this PR must made before #117261
Pre-Review Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is [exempt from version changes]. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.
Hi @NearTox thanks for contributing! Would you mind adding tests to verify the change and address the failing checks?
Hi @Piinks, the tests is contained on #8665. Since this only adds one required file, I thought it wasn't necessary.
@NearTox Can you take a look at the failing checks?
No yet, I didn't added any test so far. I will do a rebase in order to fix the conflicts
@NearTox Looks like you have some conflicts now.
@chunhtai I appreciate your support here. I hope this PR gets merged soon.