packages
packages copied to clipboard
[go_router_builder]: Fix Parameter generates a warning
Fix: https://github.com/flutter/flutter/issues/164621
Pre-Review Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1]. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under[^1].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Hi @CaoGiaHieu-dev you will also need to bump the version in package.yaml
works well, thanks @CaoGiaHieu-dev
@chunhtai is there anything else needed?
could someone finally merge this please? its been in the queue forever...
bumping this again before the tree gets out of shape yet again...
looks like there is still some conflict
not still, but again. because another commit was merged... this has been in the loop for almost 2 months ;(
@chunhtai could you merge this, please? its been in limbo for months
@vware it's not in a mergable state, as it is failing tests right now.
@CaoGiaHieu-dev can you take a look at why this is failing CI?
@Piinks cc @chunhtai Hi . sorry for late reply .
There is only one error CI When bumping the version for release, the NEXT section should be incorporated into the new version's release notes. . The NEXT section is Restricts `build` to versions less than 2.5.0. which out scoped of my pr .
There's a failure that can probably be fixed with a merge/rebase.
@CaoGiaHieu-dev Heads up that there is another failure.
@CaoGiaHieu-dev Heads up that there is another failure.
@justinmc Hi , thanks for your time. it because this issue https://github.com/flutter/flutter/issues/170832 wasnt landed yet .
I already comment about this cicd fail https://github.com/flutter/packages/pull/8889#issuecomment-3043573095
@CaoGiaHieu-dev Thanks for fixing the failures, but now there are some merge conflicts.
@Piinks can we please get this merged now? :)