packages icon indicating copy to clipboard operation
packages copied to clipboard

[go_router_builder]: Fix Parameter generates a warning

Open CaoGiaHieu-dev opened this issue 8 months ago • 9 comments
trafficstars

Fix: https://github.com/flutter/flutter/issues/164621

Pre-Review Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I linked to at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].
  • [x] I updated/added any relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under[^1].
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

CaoGiaHieu-dev avatar Mar 19 '25 02:03 CaoGiaHieu-dev

Hi @CaoGiaHieu-dev you will also need to bump the version in package.yaml

chunhtai avatar Mar 21 '25 20:03 chunhtai

works well, thanks @CaoGiaHieu-dev

vware avatar Mar 27 '25 13:03 vware

@chunhtai is there anything else needed?

vware avatar Apr 02 '25 08:04 vware

could someone finally merge this please? its been in the queue forever...

vware avatar Apr 29 '25 15:04 vware

bumping this again before the tree gets out of shape yet again...

vware avatar May 06 '25 07:05 vware

looks like there is still some conflict

chunhtai avatar May 08 '25 22:05 chunhtai

not still, but again. because another commit was merged... this has been in the loop for almost 2 months ;(

vware avatar May 09 '25 14:05 vware

@chunhtai could you merge this, please? its been in limbo for months

vware avatar May 22 '25 13:05 vware

@vware it's not in a mergable state, as it is failing tests right now.

@CaoGiaHieu-dev can you take a look at why this is failing CI?

Piinks avatar Jun 18 '25 19:06 Piinks

@Piinks cc @chunhtai Hi . sorry for late reply .

There is only one error CI When bumping the version for release, the NEXT section should be incorporated into the new version's release notes. . The NEXT section is Restricts `build` to versions less than 2.5.0. which out scoped of my pr .

CaoGiaHieu-dev avatar Jul 07 '25 06:07 CaoGiaHieu-dev

There's a failure that can probably be fixed with a merge/rebase.

justinmc avatar Jul 21 '25 18:07 justinmc

@CaoGiaHieu-dev Heads up that there is another failure.

justinmc avatar Jul 22 '25 22:07 justinmc

@CaoGiaHieu-dev Heads up that there is another failure.

@justinmc Hi , thanks for your time. it because this issue https://github.com/flutter/flutter/issues/170832 wasnt landed yet .

I already comment about this cicd fail https://github.com/flutter/packages/pull/8889#issuecomment-3043573095

CaoGiaHieu-dev avatar Jul 23 '25 01:07 CaoGiaHieu-dev

@CaoGiaHieu-dev Thanks for fixing the failures, but now there are some merge conflicts.

justinmc avatar Aug 19 '25 22:08 justinmc

@Piinks can we please get this merged now? :)

vware avatar Aug 22 '25 07:08 vware