packages icon indicating copy to clipboard operation
packages copied to clipboard

[camera_windows] Restore image streaming support

Open liff opened this issue 1 year ago • 5 comments

Restores support for streaming images from the camera(s) in Windows.

I reverted #7951 as a starting point and attempted to resolve the issues that were raised:

  • The startImageStream and stopImageStream methods are no longer async.
  • There is no global EventSink for the images. Each camera gets a dedicated EventChannel for the image data.

In addition, the images are submitted to the EventChannels from a dedicated hidden window -based task runner, based on flutter/engine#24232.

Implemented with assistance from @jokerttu.

Fixes flutter/flutter#97542.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

liff avatar Dec 05 '24 09:12 liff

From triage: This was waiting on the streaming support query API, so was blocked on that. I believe it's now unblocked.

stuartmorgan-g avatar Jan 14 '25 21:01 stuartmorgan-g

Rebased on main and added the support query.

liff avatar Jan 15 '25 17:01 liff

Attempted to address some of the review issues, will continue with the remaining stuff later.

liff avatar Feb 11 '25 21:02 liff

From triage: @liff Are you still planning on updating this PR based on the review feedback?

stuartmorgan-g avatar May 13 '25 19:05 stuartmorgan-g

From triage: @liff Are you still planning on updating this PR based on the review feedback?

Yes—though I don’t know when, I’ve been preoccupied with other stuff lately.

liff avatar May 14 '25 05:05 liff

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to re-open or submit a new PR if you have the time to address the review comments. Thanks!

Piinks avatar Jul 15 '25 22:07 Piinks