packages icon indicating copy to clipboard operation
packages copied to clipboard

[webview_flutter] Add an option to bypass SSL checks

Open Colman opened this issue 1 year ago • 2 comments

When the webview encounters an SSL error, there is no option to be able to bypass the error. This PR implements a callback that gets called with the SSL error and certificate details. A decision can be returned to either ignore the error and proceed, or cancel the request.

https://github.com/flutter/flutter/issues/36925

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Colman avatar Oct 18 '24 20:10 Colman

I still have some tests to add, but I would like a first pass to check for bigger issues

Colman avatar Oct 18 '24 22:10 Colman

Looks like webview_flutter_web (at least) doesn't have any significant changes and can be reverted?

Those changes are needed temporarily because this is a federated plugin. Please see: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins

Colman avatar Oct 22 '24 16:10 Colman

This is blocked by the ProxyApi update for Android and iOS. https://github.com/flutter/packages/pull/7794 updates Android, and a similar PR for iOS will follow shortly.

bparrishMines avatar Nov 04 '24 18:11 bparrishMines

from triage: iOS proxy updates are close to landing, at which point this will finally be unblocked.

stuartmorgan-g avatar Jan 14 '25 20:01 stuartmorgan-g

@bparrishMines Can you take a look at updating this to the new wrapper?

stuartmorgan-g avatar Feb 04 '25 20:02 stuartmorgan-g

Greetings from stale PR triage, @stuartmorgan-g is this one still blocked?

Piinks avatar Apr 18 '25 21:04 Piinks

No, it's unblocked now and needs to be updated to the new wrapper generator. @bparrishMines is planning on doing that, but has been on higher priority work. It should be pretty soon though.

stuartmorgan-g avatar Apr 19 '25 14:04 stuartmorgan-g

This PR doesn't allow me to edit so I took over this feature with: https://github.com/flutter/packages/pull/9150. Closing.

bparrishMines avatar Apr 25 '25 22:04 bparrishMines