packages
packages copied to clipboard
Upload screenshots and Xcode test results for drive and integration_test runs
https://github.com/flutter/flutter/issues/144795
Pre-launch Checklist
- [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] I read the Tree Hygiene page, which explains my responsibilities.
- [ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [ ] I signed the CLA.
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [ ] I linked to at least one issue that this PR fixes in the description above.
- [ ] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [ ] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes. - [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I added new tests to check the change I am making, or this PR is test-exempt.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
From triage: What's the status of this? Is it still something we plan to deploy? It would definitely be useful for debugging!
From triage: What's the status of this? Is it still something we plan to deploy? It would definitely be useful for debugging!
Sorry, I lost track of this. I need to page back in why the tests are failing.
@stuartmorgan this is ready to review, when you get a chance.
Is the
FLUTTER_LOGS_DIRsupport low-level enough that it already applies to this repo, or do we need recipe changes too?
It already applies as of https://flutter-review.googlesource.com/c/recipes/+/39703
You can see it in the env: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8732173142577412545/+/u/Run_package_tests/xcode_analyze_deprecation/l_execution_details