packages
packages copied to clipboard
flutter
[google_maps_flutter_ios] Fixed map objects being added to the map before all properties are set
This changes the iOS maps package to ensure that each map object (Marker, Polygon, Polyline, Circle, and Tile) is added to the map after all of their properties (fillColor, strokeColor, etc.) are set. This fixes this issue:
https://github.com/flutter/flutter/issues/143570
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
![flutter-dashboard[bot] avatar](https://avatars.githubusercontent.com/in/64368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Colman Are you still planning on updating this PR to address the review comments above?
@Colman Are you still planning on updating this PR to address the review comments above?
Hi @stuartmorgan, I'm waiting on a reply from @cbracken in one of the comments above.
From triage: @Colman did my reply in that comment thread address the blocking issue?
Hello there, ping @cbracken @Colman to fix / answer the comments so we can merge this 😛
Hi, I've been very busy lately and haven't had time to look at this PR. Sorry about that. I will most likely get to it next week.
This will need to be resolved for the recent conversion to Pigeon data structures; sorry about that conflict. The change should be easy to resolve though since you can just move the relevant line to the end in the new version.