packages icon indicating copy to clipboard operation
packages copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[camera] Camera web mobile orientation

Open kristoffer-zliide opened this issue 1 year ago • 3 comments
trafficstars

Various orientation-related fixes for camera in mobile browsers, including https://github.com/flutter/flutter/issues/143288 and https://github.com/flutter/flutter/issues/117430. The improved video constraints might also fix the zoom behavior observed in https://github.com/flutter/flutter/issues/112280. Previously closed as https://github.com/flutter/packages/pull/6362.

Fixes https://github.com/flutter/flutter/issues/143288

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the [CLA].
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I [linked to at least one issue that this PR fixes] in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • [ ] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] All existing and new tests are passing.

kristoffer-zliide avatar Jun 24 '24 09:06 kristoffer-zliide

From triage: ping @ditman and @bparrishMines on this review.

stuartmorgan-g avatar Jul 23 '24 19:07 stuartmorgan-g

@kristoffer-zliide Are you still planning on updating this based on the review comments above?

stuartmorgan-g avatar Sep 10 '24 19:09 stuartmorgan-g

Fixes https://github.com/flutter/flutter/issues/143288

harryterkelsen avatar Sep 12 '24 18:09 harryterkelsen

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

stuartmorgan-g avatar Oct 29 '24 19:10 stuartmorgan-g

You're welcome, @stuartmorgan! I totally understand that. Good luck with your project and its 12.500+ open issues.

kristoffer-zliide avatar Oct 31 '24 13:10 kristoffer-zliide

Good luck with your project and its 12.500+ open issues.

We have not found that leaving PRs open indefinitely when the authors haven't responded to questions or comments in several months helps reduce the issue count. It just makes the number of open PRs go up over time, making it harder to focus on active PRs, thus our policy of closing PRs when we don't receive any response from the author for an extended period.

stuartmorgan-g avatar Oct 31 '24 16:10 stuartmorgan-g