packages icon indicating copy to clipboard operation
packages copied to clipboard

[animations] Adds ability to show a translucent modal route

Open matheuslutero opened this issue 2 years ago • 6 comments

Currently the _OpenContainerRoute.opaque property is fixed to true, this change will add the ability to set this value to false if needed. This way we will be able to push a translucent route.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

matheuslutero avatar Dec 03 '23 00:12 matheuslutero

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 03 '23 00:12 google-cla[bot]

I am curious to see what visual effect you are going for with this option. Do you have an example of how you intent to use this? The open container animation was very much designed with the expectation that the opened container would cover the entire old content...

goderbauer avatar Dec 04 '23 18:12 goderbauer

[x] I listed at least one issue that this PR fixes in the description above.

@matheuslutero Could you file a proposal issue with a more detailed use case, to answer the question above, and link it here?

stuartmorgan-g avatar Jan 09 '24 20:01 stuartmorgan-g

Hi folks, sorry for the late reply. I'll have some time next weekend, so I will attach an example of this usage here.

matheuslutero avatar Jan 16 '24 02:01 matheuslutero

I will attach an example of this usage here.

Please file a proposal issue, as requested above and described here, rather that making the proposal in the PR.

stuartmorgan-g avatar Jan 16 '24 12:01 stuartmorgan-g

@matheuslutero Is the proposal discussed above still something you are planning on moving forward with?

Marking as a draft for now since there's not yet sufficient context for a code review.

stuartmorgan-g avatar Mar 05 '24 20:03 stuartmorgan-g

(triage) I am going to close this one since there was no follow-up. If you find the time to work on this again please feel free to reopen the PR.

goderbauer avatar May 07 '24 22:05 goderbauer