packages
packages copied to clipboard
[rfw] Add web implementation for the rfw wasm example
Fixes https://github.com/flutter/flutter/issues/129384.
- Slightly updated the readme section
- Split networking and wasm implementations into 2 files since the upstream APIs for desktop and web are very different
- I left the binary encoding bits for rfw, but since dart2js doesn't support 64 bit int, I did the demo in dart2wasm web
- I removed the local caching bit. It's probably a distraction from the core of the demo. Since the web implementation will need to work very differently, I think it distracts from the main demo.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
Sorry it took me forever to follow up, I totally forgot about this PR. Please ping me when you want it reviewed again, I get too much GitHub notification spam to be able to rely on that.
I synced this again since stable is out now. PTAL
Merged in main now that stable has been updated.
@xster Are you still planning on updating the PR to make it landable?