packages icon indicating copy to clipboard operation
packages copied to clipboard

[google_maps_flutter_web] Add padding to newLatLngBounds implementation

Open jxstxn1 opened this issue 2 years ago • 1 comments

Description

This PR is implementing the padding argument to fitBounds which is called by newLatLngBounds.

Related Issues

flutter/flutter#122192

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jxstxn1 avatar Mar 13 '23 17:03 jxstxn1

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 13 '23 17:03 flutter-dashboard[bot]

@ditman Can you do the initial review here? It looks like this one should be pretty quick.

stuartmorgan-g avatar Mar 28 '23 19:03 stuartmorgan-g

@stuartmorgan @ditman Is there any update here?

jxstxn1 avatar May 03 '23 21:05 jxstxn1

Update from triage: This is just waiting for @ditman to have bandwidth to review maps PRs.

stuartmorgan-g avatar May 16 '23 19:05 stuartmorgan-g