[google_maps_flutter_android, url_launcher_android] bump roboelectric version
Update roboelectric version to 4.4.1 to remove usages of 'android.support' and support androidX without jetifier. https://github.com/robolectric/robolectric/issues/5523
https://github.com/flutter/flutter/issues/117107
Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated
CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style]. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] All existing and new tests are passing.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
Thank you for your contribution. It looks like the tests are failing. Before we review the PR, please see what you can do to resolve the test failures. If you are unsure how to proceed, please reach out for help on the #hackers-new channel.
Thanks! I forgot to run native_tests locally. @camsim99 Found that the tests failed because of RoboElectric 4.4 moved to newer LooperMode.Mode.PAUSED. With @LooperMode(LooperMode.Mode.LEGACY) the tests succeeded. I added fix suggested here: https://github.com/robolectric/robolectric/issues/5356#issuecomment-587554545 Should this be investigated why test succeed with LEGACY mode and fail with PAUSED mode?
@camsim99 Just notifying. PR needs one more review.