packages icon indicating copy to clipboard operation
packages copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[pigeon] Add Kotlin parameters to run pigeon command

Open paolorotolo opened this issue 2 years ago • 4 comments

Add example parameters to generate Kotlin code in pigeon's example as described in the attached issue.

I didn't update pigeon changelog since pigeon/example/README.md isn't published on pub.dev.

Thanks!

List which issues are fixed by this PR. You must list at least one issue. https://github.com/flutter/flutter/issues/121238

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy. N/A

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

paolorotolo avatar Feb 22 '23 16:02 paolorotolo

Sorry about that, I thought that just the main README.md was published on pub.dev. I'm seeing now that the example/README is there too. I'll update the pr ASAP.

paolorotolo avatar Feb 23 '23 17:02 paolorotolo

I've updated CHANGELOG and pubspec and rebased with upstream.

paolorotolo avatar Feb 23 '23 19:02 paolorotolo

Not sure why tests are still failing

paolorotolo avatar Feb 23 '23 20:02 paolorotolo

Got it, clang-format was not installed on my machine. Should be fine now.

paolorotolo avatar Feb 23 '23 21:02 paolorotolo

@stuartmorgan I believe this is ready for a second review now.

tarrinneal avatar Feb 24 '23 19:02 tarrinneal

Some other Pigeon PRs landed; could you re-rev the version here?

stuartmorgan-g avatar Feb 28 '23 20:02 stuartmorgan-g