packages icon indicating copy to clipboard operation
packages copied to clipboard

[flutter_adaptive_scaffold] Add more built-in Animation

Open CyberNika opened this issue 2 years ago • 4 comments

Adds three new Animations:

  • slideOnFromTop for topNavigation
  • slideOffToTop for topNavigation
  • slideOffToRight

Renames five existing Animations:

  • bottomToTop => slideOnFromBottom
  • topToBottom => slideOffToBottom
  • leftOutIn => slideOnFromLeft
  • leftInOut => slideOffToLeft
  • rightOutIn => slideOnFromRight

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

CyberNika avatar Feb 21 '23 03:02 CyberNika

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Feb 21 '23 03:02 flutter-dashboard[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 21 '23 03:02 google-cla[bot]

@heynext you will also need to add tests for your changes before we can proceed with this PR, since all changes need to have tests.

gspencergoog avatar Feb 28 '23 21:02 gspencergoog

@heynext Are you still planning on updating this PR based on the feedback above?

stuartmorgan-g avatar Mar 21 '23 19:03 stuartmorgan-g

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

stuartmorgan-g avatar Apr 18 '23 19:04 stuartmorgan-g