packages icon indicating copy to clipboard operation
packages copied to clipboard

[flutter_migrate] Resolve conflicts command

Open GaryQian opened this issue 3 years ago • 5 comments

Previously mid-way through review: https://github.com/flutter/flutter/pull/102790

Resolve conflicts wizard. Finds and displays each staged merge conflict and presents options to the developer to accept old, accept new, or skip.

Between each file, the wizard asks developers to commit the changes or not.

This tool exists to help rapidly process routine conflicts that may be generated by the migrate tool. Typical usage is to usually accept the new changes unless something was explicitly manually set. Complex conflicts can be skipped and left to be merged manually.

GaryQian avatar Oct 21 '22 21:10 GaryQian

@christopherfujino You previously reviewed the old version of this PR. The suggestions you made there are carried forwards into this one.

GaryQian avatar Oct 25 '22 18:10 GaryQian

Added @stuartmorgan since he's been reviewing other migrate PRs, and might have the most up-to-date context.

zanderso avatar Nov 14 '22 16:11 zanderso

@stuartmorgan Addressed comments and ready for another look! Thanks.

GaryQian avatar Jan 10 '23 17:01 GaryQian

@christopherfujino Ready for another look!

GaryQian avatar Jan 18 '23 20:01 GaryQian

Let me know if you still want this to land. If not we can take it over.

reidbaker avatar Jan 23 '23 20:01 reidbaker

@reidbaker Did you want to take this PR over, or should we close it for now and revisit later?

stuartmorgan-g avatar Mar 07 '23 20:03 stuartmorgan-g

I think close and revisit

reidbaker avatar Mar 07 '23 20:03 reidbaker

Closing; filed https://github.com/flutter/flutter/issues/122305 with a breadcrumb back to this PR for when flutter_migrate is revisited.

stuartmorgan-g avatar Mar 09 '23 16:03 stuartmorgan-g