[go_router] Add support for Iterable, List and Set to TypedGoRoute

[Skogsfrae]

Add support for Iterable, List and Set to TypedGoRoute

Changed signature of GoRouteData.$location for PR #2679 Resolves Issue #108437

Pre-launch Checklist

• [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• [x] I signed the [CLA].
• [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• [x] I listed at least one issue that this PR fixes in the description above.
• [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
• [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
• [x] I updated/added relevant documentation (doc comments with ///).
• [x] I added new tests to check the change I am making, or this PR is [test-exempt].
• [x] All existing and new tests are passing.

[flutter-dashboard[bot]]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[stuartmorgan-g]

@chunhtai From triage: ping on this review.

[chunhtai]

Updates: this one is waiting on https://github.com/flutter/packages/pull/2679

[chunhtai]

Hi @Skogsfrae looks like there are ci failures and merge conflict. can you rebase off the latest main and fix the ci?

[Skogsfrae]

Hi @chunhtai I finally managed to make the ci work. I temporarily modified the analysis_options.yaml to skip go_router_builder example app .g.dart files. I'll restore it in the go_router_builder pr after this gets merged

[Skogsfrae]

If someone can please add the override: no changelog needed I'll update the pr to solve the conflicts and the CI could run without the previous changelog problem

[stuartmorgan-g]

Overriding for go_router_builder; ignores are dev-only changes.

[Skogsfrae]

@chunhtai this is ready to be merged

[stuartmorgan-g]

@johnpryan Who should do the second review on this?

[stuartmorgan-g]

@chunhtai It looks like you reviewed this before, could you re-review as the second reviewer?

[chunhtai]

@Skogsfrae can you rebase off latest main?

[Skogsfrae]

@chunhtai I rebased both this pr and the one on go_router_builder

[Skogsfrae]

@chunhtai I just rebased it again with the last release. Is there something else that needs to be done to merge this PR?

[Skogsfrae]

@chunhtai @stuartmorgan @johnpryan can this PR be merged so I can update the linked one and hopefully have that merged too? I'm keeping this updated with upstream and I'd really like to be able to use this feature with go_router_builder

Thank you guys 🙏🏼

[stuartmorgan-g]

Based on the last comments from reviewers it looks like this is ready to land and just didn't get the label.