Support launching a HTTPS URL

[Wdestroier]

trafficstars

I setup a reverse proxy, but this piece of code only allows launching HTTP URLs. I'm submitting a patch to fix the error.

See issue comment https://github.com/Dart-Code/Dart-Code/issues/5322#issuecomment-2704159264 for context.

Pre-launch Checklist

• [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
• [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
• [ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• [X] I signed the CLA.
• [ ] I listed at least one issue that this PR fixes in the description above.
• [ ] I updated/added relevant documentation (doc comments with ///).
• [ ] I added new tests to check the change I am making, or this PR is test-exempt.
• [ ] I followed the breaking change policy and added Data Driven Fixes where supported.
• [ ] All existing and new tests are passing.

[flutter-dashboard[bot]]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[bkonyi]

Hi @Wdestroier, thanks for your contribution!

We're going to need some tests in order to land this. Let me know if you have any questions and I'll be happy to help!

[bkonyi]

Hi @Wdestroier! Do you still intend to pick this back up?

[Wdestroier]

Hi, I will pick this today.

[Wdestroier]

Done, @bkonyi! Can you review it, please?

[Wdestroier]

@bkonyi, I updated my branch with upstream to fix the "ci.yaml validation" error.

[bkonyi]

Sorry for the delay @Wdestroier. LGTM!

[Piinks]

Hey @Wdestroier do you have plans to return to this PR and address the above feedback?

[Wdestroier]

Hi, I will prioritize this today.

[Wdestroier]

Great idea, @matanlurey! Sorry for the delay. Can you review the changes, please?

[bkonyi]

LGTM. @matanlurey is OOO this week, so I've added @jtmcdole for a rubber stamp.

It looks like you'll need to resolve some conflicts before this can land, however.

[Wdestroier]

Fine. I solved the merge conflicts. Thanks!

[bkonyi]

There's still a couple of failures that will block this from landing :-(

[jtmcdole]

Needs a format:

Found 1 Dart file which was formatted incorrectly.
To fix, run `dart format packages/flutter_tools/test/general.shard/web/devices_test.dart` or:

git apply <<DONE
diff --git a/packages/flutter_tools/test/general.shard/web/devices_test.dart b/packages/flutter_tools/test/general.shard/web/devices_test.dart
index ce6b23abc17..00000000000 100644
--- a/packages/flutter_tools/test/general.shard/web/devices_test.dart
+++ b/packages/flutter_tools/test/general.shard/web/devices_test.dart
@@ -246,8 +246,9 @@ void main() {
       processManager: processManager,
     );
 
-    final GoogleChromeDevice chromeDevice =
-        (await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;
+    final GoogleChromeDevice chromeDevice = (await webDevices.pollingGetDevices())
+        .whereType<GoogleChromeDevice>()
+        .first;
 
     expect(await chromeDevice.isSupported(), true);
     expect(await chromeDevice.sdkNameAndVersion, 'ABC');
@@ -288,8 +289,9 @@ void main() {
       processManager: processManager,
     );
 
-    final GoogleChromeDevice chromeDevice =
-        (await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;
+    final GoogleChromeDevice chromeDevice = (await webDevices.pollingGetDevices())
+        .whereType<GoogleChromeDevice>()
+        .first;
 
     expect(await chromeDevice.isSupported(), true);
     expect(await chromeDevice.sdkNameAndVersion, 'Google Chrome 74.0.0');
@@ -492,3 +494,4 @@ class _OnceClosableChromium extends Fake implements Chromium {
 }
 
 class _UnimplementedChromium extends Fake implements Chromium {}
DONE

[auto-submit[bot]]

autosubmit label was removed for flutter/flutter/164720, because This PR has not met approval requirements for merging. Changes were requested by {matanlurey}, please make the needed changes and resubmit this PR. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.